Add device s200

[albertsal]

I added the s200 sport device management similar to the MAKIBESF68 ..

I modified the showIncomingCall logic, showText,
encodeStringToDevice.

The device works in unicode but for incoming calls is mixed

[ashimokawa]

Thanks!

Can you please remove all the formatting changes? Whitespaces and tabs.

Also please do the same indention as we do (default Android Studio)

[albertsal]

@ashimokawa sorry ... i use project settings ... can you tell me the parameters to set?

[cpfeiffer]

Pretty cool and looks good to me.

The formatting changes are actually the cause of using the project default formatting rules, so actually make it consistent. It would've been better to have the formatting changes separate from content changes, but it's always a pain to do this after the fact.

One question, also directed at @jpbarraca -- do you prefer to have DeviceType checks in the code or prefer using separate classes per device (or per device that is different enough to warrant a separate class).

I always prefer to separate things to prevent many if-clauses, but if the number of if-clauses stays small, it's OK.

Any other comments @jpbarraca?

[jpbarraca]

I prefer having different classes overriding the default behaviour whenever necessary. Especially in this case where the number of different devices may be large.

The rest of the code seems to be ok.

[ashimokawa]

@jpbarraca
Welcome back ;)
Do you want to merge this and then change the code according to your taste?

About the indention, it would be cool if you could use the same style as android studio default which we are using to prevent unrelated formatting changes from happening.

[jpbarraca]

@albertsal How can we distinguish the S200 from the other HPLUS devices?

[albertsal]

As for the MAKIBESF68 also s200 starts with SPORT

[jpbarraca]

Is there an additional message supported? or a characteristic? If nothing is available we will have to resort to a configuration option.

What is the hardware and firmware versions?

[albertsal]

I attach the information I get

gadgetbridge.txt

[jpbarraca]

I find it odd that this is required (mixed language support). Also I find not accurate method to identify the device type.
What is the problem that you find with the current version?
Also, can you please try this version ?

[albertsal]

For messages it requires unicode but for calls if I use unicode he writes in chinese
Ok I try your version

[albertsal]

When I receive a message, the message is displayed with spaces .... I have solved this problem by applying the first 2 bytes characteristic of the unicode only at the beginning of the message the remaining characters apply only the final 0 .... do Reference to my code ...

Regarding Chinese call visualization calls (this problem is also visible with hplus) I have solved not using unicode for this function

I forgot s200 does not support concatenated messages so I set a maximum number of characters to use all the space ... I also inserted small optimizations like truncating the message object to use the best available space