Helm with dashboard changes #4
Conversation
…Url" and "catalogUrl" for the companies
…and expose NodePort
system-tests/helm/README.md
Outdated
| ```yaml | ||
| edc-connector-dashboard: | ||
| build: | ||
| #e.g. /home/user/RegistrationService/launcher |
There was a problem hiding this comment.
clarification(blocking): I do not have this folder in my local setup, what should been done in this case?
There was a problem hiding this comment.
We need to checkout edc-dashboard(https://github.com/FraunhoferISST/edc-dashboard/), branch: helm_dashboard_changes. The Dockerfile in this repository is used to generate the images for company data dashboards (UI).
The updated README.md file contains the instruction about this step.
system-tests/helm/README.md
Outdated
| kind create cluster --config=kind-cluster.yaml | ||
| ``` | ||
|
|
||
| Create the docker images in the host machine, ```docker compose -f docker-compose.yml build``` |
There was a problem hiding this comment.
clarification(blocking): The editing of the docker-compose is not meantioned. This example would not work without knowing this.
There was a problem hiding this comment.
The last commit of this repository contains an updated README.md file.
This includes instruction to set the edc-dashboard repository path.
system-tests/helm/README.md
Outdated
| * a kubernetes cluster, and | ||
| * helm installed | ||
|
|
||
| You can use [minikube](https://minikube.sigs.k8s.io/docs/) or [kind](https://kind.sigs.k8s.io/) |
There was a problem hiding this comment.
suggestions(non-blocking): A requirements section could be cleaner, to see which applications and version numbers have to be installed.
There was a problem hiding this comment.
The updated README.md contains more details on the tools we need and their versions.
system-tests/helm/README.md
Outdated
|
|
||
|
|
||
| ## Mounting Resources | ||
| All the necessary resources needed by these applications are in the directory [./k8s_resources](./k8s_resources). |
There was a problem hiding this comment.
nitpick(non-blocking): "these applications", which ones?
There was a problem hiding this comment.
This line has been omitted in the latest commit.
system-tests/helm/README.md
Outdated
| Then execute ```docker compose -f docker-compose.yml build``` | ||
|
|
||
| It will create the following docker images in minikube's docker environment: | ||
| ```registration-service:v.01```, ```edc-connector:v.01```, ```cli-tools:v.01```, ```edc-connector-dashboard:v.01```. |
There was a problem hiding this comment.
question(non-blocking): what versioning schema/convention is this? i am unfamiliar with this type of schema
There was a problem hiding this comment.
The versions of the images have been updated to v0.2.0. I have tried to keep the version similar to the edc-version we are using.
system-tests/helm/README.md
Outdated
| @@ -0,0 +1,115 @@ | |||
| # Helm Charts for MVD | |||
There was a problem hiding this comment.
suggestion(non-blocking): "MVD on Kubernetes", This section explains how to deploy on K8s not the charts
There was a problem hiding this comment.
The title has been updated according to the suggestion. latest commit.
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
No description provided.