Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chris8205 patch 2 #1986

Merged
merged 20 commits into from
Sep 24, 2024
Merged

Chris8205 patch 2 #1986

merged 20 commits into from
Sep 24, 2024

Conversation

hylkevds
Copy link
Member

Rebase of #1982 on v2.x

phertweck
phertweck requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@phertweck phertweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

helm/frost-server/templates/_helpers.tpl Show resolved Hide resolved
helm/frost-server/templates/_helpers.tpl Show resolved Hide resolved
helm/frost-server/templates/_helpers.tpl Show resolved Hide resolved
helm/frost-server/values.yaml Outdated Show resolved Hide resolved
helm/frost-server/values.yaml Outdated Show resolved Hide resolved
helm/frost-server/templates/_helpers.tpl Outdated Show resolved Hide resolved
helm/frost-server/templates/db-deployment.yaml Outdated Show resolved Hide resolved
helm/frost-server/templates/db-deployment.yaml Outdated Show resolved Hide resolved
helm/frost-server/templates/http-ingress.yaml Outdated Show resolved Hide resolved
helm/frost-server/.vscode/settings.json Outdated Show resolved Hide resolved
@mikedolx
Copy link

Hi @phertweck,

do you need further information to process this PR, or are you waiting for @chris8205 to push the changes?

Thanks and BR,
Michael;

@hylkevds
Copy link
Member Author

do you need further information to process this PR, or are you waiting for @chris8205 to push the changes?

There are some open questions of Philipp that are not addressed yet.
And the helm-build throws an error, that will need fixing too...

@chris8205
Copy link
Contributor

do you need further information to process this PR, or are you waiting for @chris8205 to push the changes?

There are some open questions of Philipp that are not addressed yet. And the helm-build throws an error, that will need fixing too...

please take a look at
chris8205:patch-1
i've worked a second time on it... but i think there is a mis match i dont know how i can push those changes into "patch2"

chris8205 and others added 18 commits September 20, 2024 08:47
@chris8205 @hylkevds
Update values.yaml
752f08c 
Test Try
@chris8205 @hylkevds
common Labels Annotations
f8519e9
@chris8205 @hylkevds
Update http-ingress.yaml
dfe4ade 
add Version compatibility
add conditional to annotations
add conditional to rewriteroule
@chris8205 @hylkevds
Update values.yaml
24e6ddb
@chris8205 @hylkevds
Update values.yaml
6360546 
add same schema to mqtt ingress
@chris8205 @hylkevds
Update mqtt-ingress.yaml
64877e2 
add ingressClassName
@chris8205 @hylkevds
Update http-deployment.yaml
3191105 
add lifeness and readyness
@chris8205 @hylkevds
Update mqtt-deployment.yaml
4901a88 
add liveness
readyness
@chris8205 @hylkevds
Update bus-deployment.yaml
4cbcc2f 
lifeness probes
@chris8205 @hylkevds
Update db-deployment.yaml
97fc8cc 
lifeness probe
@hamelchRIT @hylkevds
Test
366869e
@hamelchRIT @hylkevds
many mods
42a7c53
@chris8205 @hylkevds
multiple changes
7c06a0f
@chris8205 @hylkevds
multiple changes2
2e6e965
@chris8205 @hylkevds
Delete helm/frost-server/.vscode directory
11ff03d
@chris8205 @hylkevds
Delete helm/frost-server/charts/common-2.22.0.tgz
c68434d
@chris8205 @hylkevds
fix templating issues
09cd334
@chris8205 @hylkevds
fix accidently removed definition
6769b39
@hylkevds
Copy link
Member Author

please take a look at chris8205:patch-1 i've worked a second time on it... but i think there is a mis match i dont know how i can push those changes into "patch2"

I've cherry-picked your additional commits onto this branch, and the changes to the helm-subtree are now the same.
However, the helm-build is still failing: https://github.com/FraunhoferIOSB/FROST-Server/actions/runs/10954615154/job/30416872212?pr=1986

Also, can you document and breaking changes in the CHANGELOG.md file?

chris8205 and others added 2 commits September 23, 2024 08:24
@chris8205 @hylkevds
fix helmbuild 'chris8205-patch-2'
ede7000 
/tmp/helm dependency update ./helm/frost-server

to get the dependency to the broadcom common-chart
@hylkevds
Updated helm version used for building
dbf9637
@hylkevds hylkevds mentioned this pull request Sep 23, 2024
Closed
@hylkevds hylkevds merged commit 792a7da into v2.x Sep 24, 2024
2 checks passed
@hylkevds hylkevds deleted the chris8205-patch-2 branch September 24, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris8205 chris8205 chris8205 left review comments

@phertweck phertweck phertweck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hylkevds @mikedolx @chris8205 @phertweck @hamelchRIT