Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration tests #159

Merged
merged 17 commits into from
Sep 6, 2024
Merged

add integration tests #159

merged 17 commits into from
Sep 6, 2024

Conversation

tbischoff2
Copy link
Collaborator

No description provided.

Copy link
Member

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests themselves look good.
Is there a way to exclude the execution of integration test when building? This should be possible as integration test typically have much longer runtime than regular unit tests and are often excluded when doing a regular build.
A possible solution would be to have a separate test project and corresponding configuration in the parent POM similar to what we have in FA³ST Service. However, this also requires additional configuration in the POM(s) and maybe Github CI but we should be more or less able to copy that from the Service

spring.jpa.properties.hibernate.format_sql=true
spring.jpa.hibernate.ddl-auto=update
spring.jpa.open-in-view=true
server.port=8090
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? I assume that random ports are used in the tests and setting a port in the config would not be needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, random pprts are used. I removed the port.

Copy link

sonarcloud bot commented Sep 4, 2024

@tbischoff2
Copy link
Collaborator Author

As the integration tests are triggered separately via the maven-failsafe-plugin, they can be skipped with "skipITs", indendepent of the project they are located in.

@mjacoby mjacoby merged commit abd2cfb into main Sep 6, 2024
3 checks passed
@mjacoby mjacoby deleted the feature/integrationTests branch September 6, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants