Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support iframes and portals #28

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix: support iframes and portals #28

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0aaecd4
Fix: support iframes and portals
sielay Aug 23, 2023
612a307
Fix: support iframes and portals
sielay Aug 23, 2023
64f5151
More transparent approach and now builds
sielay Aug 23, 2023
7a39e64
More uses
sielay Aug 23, 2023
2e21ddf
Missing references to window
sielay Aug 23, 2023
a40ad2d
Missing document references
sielay Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ the editing behavior of the hook:
- The `indentation` option may be a number of displayed spaces for indentation. This also enables the
improved `Tab` key behavior, which will indent the current line or dedent the current line when shift is
held (Be aware that this will make the editor act as a focus trap!)
- The `window` allows to provide a `MutableRefObject<Window>` to other window. It's useful when you use React portal
to render content in an iframe.

When `options.indentation` is set then `useEditable` will prevent the insertion of tab characters and
will instead insert the specified amount of whitespaces, which makes handling of columns much easier.
Expand Down Expand Up @@ -193,7 +195,6 @@ imitating `onChange` otherwise, while the editable is selected.
- [`codemirror.next`](https://github.com/codemirror/codemirror.next) is an invaluable source to see different techniques when
handling text input and DOM update tricks.


## Maintenance Status

**Stable:** Formidable is not planning to develop any new features for this project. We are still responding to bug reports and security concerns. We are still welcoming PRs for this project, but PRs that include new features should be small and easy to integrate and should not include breaking changes.
Loading