Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN Owl and new size for featured badges #67

Merged
merged 6 commits into from
Jun 23, 2022

Conversation

ryansrofe
Copy link
Contributor

This PR includes the following:

  • added React Native Owl as a Featured Badge
  • added a new small logo option for Featured Badges that only includes the icon and no text
  • compressed all SVGs and retained the class names (inner-ring & outer-ring) for hover effects
  • added role="img" and aria-labelledby=[id] to each SVG with a corresponding <title id="[id]"> following accessibility guidelines outlined in this article: Creating Accessible SVGs by Carie Fisher This effort was picked up from PR36 <- this PR can be closed with this update. 💅
  • we should consider testing and merging PR35 to see if it indeed fixes the console warnings when using featured badges.

these svg files have been compressed leaving classNames intact, also added role and aria-labelledby attributes
these svg files have been compressed leaving classNames intact, also added role and aria-labelledby attributes
add all additional props for featured badge
@ryansrofe ryansrofe added the enhancement New feature or request label Jun 23, 2022
README.md Show resolved Hide resolved
@jpdriver jpdriver self-requested a review June 23, 2022 16:21
Copy link
Contributor

@jpdriver jpdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, and love that you added the a11y stuff too!

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOPE

@ryansrofe ryansrofe merged commit f76c32d into master Jun 23, 2022
@ryansrofe ryansrofe deleted the feature/badges-logos-only branch June 23, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants