New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add isSortable to SmartFieldOptions type #914

Open

gventuri wants to merge 1 commit into ForestAdmin:main from gventuri:main

gventuri commented Feb 14, 2022

Definition of Done

I added isSortable to type SmartFieldOptions. It is a valid param for a field, and should be accepted by typescript (check it out here: https://github.com/ForestAdmin/forest-express/blob/main/src/services/apimap-fields-formater.js).

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)
Ensure that Types have been updated according to your changes (if needed)

Security

Consider the security impact of the changes mad


          fix: add isSortable to SmartFieldOptions type

baaa2fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet