Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add baseUrl to SmartActionOptions #1103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThibautCuchet
Copy link

@ThibautCuchet ThibautCuchet commented Feb 22, 2024

Definition of Done

General

The SmartActionOptions type was missing the props baseUrl available in the forest-express package.

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant