rename point_types to point_xyzir #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autumn60
reviewed
Aug 16, 2024
| #ifndef VELODYNE_CLOUD_SEPARATOR__POINT_TYPES_HPP_ | ||
| #define VELODYNE_CLOUD_SEPARATOR__POINT_TYPES_HPP_ | ||
| #ifndef VELODYNE_CLOUD_SEPARATOR__POINT_XYZIR_HPP_ | ||
| #define VELODYNE_CLOUD_SEPARATOR__POINT_XYZIR_HPP_ |
There was a problem hiding this comment.
インクルードガード名をPOINT_XYZIR_HPP_に変えてほしいです。（ディレクトリ構造と一致させるため）
There was a problem hiding this comment.
現時点で、インクルードガード名とディレクトリ構造は一致していると思います。
Autumn60
requested changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
velodyne_cloud_separatorのpoint_types.hppをpoint_xyzir.hppにリネームする #114