Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable long line checks in syntax check #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

warpr
Copy link
Contributor

@warpr warpr commented Aug 24, 2022

Problem

Sometimes it useful to reference documentation in code comments, for example when documenting the contents of fields provided by a third-party API or integration. This can look like:

// - slot_start_sec: Start time of the appointment slot in seconds of UTC time since Unix epoch.
// https://developers.google.com/maps-booking/verticals/local-services/reference/rest-api-v3/bookings/slot-specification
$start = new DateTime('@' . $booking->slot_start_sec);

Currently the syntax checker doesn't allow long lines like this, and there is no way to
disable the check for just this line.

Solution

Just disable the max line length check -- we don't need it for most files, as most existing files and all new files are processed with prettier, which will take care of the long line formatting where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant