Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous methods on Grads #1486

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove superfluous methods on Grads #1486

wants to merge 2 commits into from

Commits on Dec 31, 2023

  1. Remove superfluous methods on Grads 

    As far as I can tell, these were never used, tested or documented.
Moreover, they don't make sense semantically since `Grads` behaves like a Dict rather than an ordinal-indexed collection like an Array.
Meanwhile, their continued existence is causing issues like #1484.
    @ToucheSir
    ToucheSir authored Dec 31, 2023
    Configuration menu
    Copy the full SHA
    c8fe70d View commit details
    Browse the repository at this point in the history

  2. Remove broadcast-related ambiguity with Params

    @ToucheSir
    ToucheSir authored Dec 31, 2023
    Configuration menu
    Copy the full SHA
    2cd611e View commit details
    Browse the repository at this point in the history