Extend kron support #1458
Merged
Extend kron support #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
approved these changes
Sep 27, 2023
|
Has it caused you problems previously? |
Maybe in the not-so-distant future: |
Not so much. It was just frustrating to have CI broken for so long (in Zygote and Tracker) because of changes in Base and to have to patch the issue in the AD itself instead of in ChainRules. I'm glad to see progress is being made on a proper rule :) |
Pangoraw
pushed a commit
to Pangoraw/Zygote.jl
that referenced
this pull request
Dec 4, 2023
* Bump patch * Generalise kron implementation
Pangoraw
pushed a commit
to Pangoraw/Zygote.jl
that referenced
this pull request
Dec 4, 2023
* Bump patch * Generalise kron implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
kronrules do not handlekron(::AbstractMatrix, ::AbstractVector)orkron(::AbstractVector, ::AbstractMatrix). This PR adds support for both. Fortunately, the implementation strategy is precisely the same as the one currently taken.A method of
_pullbackforkronis removed in favour of a single method of_pullbackwhich can handle all four combinations of argument types.Fixes JuliaGaussianProcesses/TemporalGPs.jl#115
PR Checklist