Fix reverse failure
#1396
Merged
Fix reverse failure
#1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Mar 14, 2023
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
devmotion
reviewed
Mar 14, 2023
|
Would be good to have some tests of an end use, i.e. |
:) Co-authored-by: David Widmann <[email protected]>
I added the MWE from #1393. Any others that come to mind? |
simsurace
commented
Mar 15, 2023
devmotion
approved these changes
Mar 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #1393 by adding an internal function
_reversethat now has some specializations for known cases in which the fallbackreversefails. This preserves the general behavior that was introduced by #1376 while fixing the known bugs it introduced.