Merge #389

389: Add tests for sum with closed over variable and generator. Issue #231 r=MikeInnes a=baggepinnen Co-authored-by: Fredrik Bagge Carlson <[email protected]>
FluxML · Nov 4, 2019 · dcdc4fa · dcdc4fa
2 parents 152fbdd + 472332d
commit dcdc4fa
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/test/gradcheck.jl b/test/gradcheck.jl
@@ -46,6 +46,9 @@ Random.seed!(0)
 @test gradtest(x -> sum(x, dims = (2, 3)), (3,4,5))
 @test gradtest(x -> sum(abs2, x), randn(4, 3, 2))
 @test gradtest(x -> sum(abs2, x; dims=1), randn(4, 3, 2))
+@test gradtest(x -> sum(x[i] for i in 1:length(x)), randn(10))
+@test_broken gradtest(x -> sum(i->x[i], 1:length(x)), randn(10)) # https://github.com/FluxML/Zygote.jl/issues/231
+
 @test_broken gradtest(x -> prod(x, dims = (2, 3)), (3,4,5))
 @test gradtest(x -> prod(x), (3,4,5))