Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some v0.13 deprecations #2493

Merged
merged 8 commits into from
Oct 12, 2024
Merged

remove some v0.13 deprecations #2493

merged 8 commits into from
Oct 12, 2024

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Oct 11, 2024

Remove v0.13 deprecations except for the old optimizers, which require more care and a separate PR.

This also

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.92%. Comparing base (b0c6653) to head (2cac684).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2493      +/-   ##
==========================================
- Coverage   41.26%   38.92%   -2.35%     
==========================================
  Files          37       37              
  Lines        2118     2063      -55     
==========================================
- Hits          874      803      -71     
- Misses       1244     1260      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello CarloLucibello changed the title remove v0.13 deprecations remove some v0.13 deprecations Oct 11, 2024
@CarloLucibello
Copy link
Member Author

CarloLucibello commented Oct 11, 2024

Docs CI error is not related to this PR and will be fixed in #2492.
This seems ready to go!

@ToucheSir
Copy link
Member

Should we update https://github.com/FluxML/Flux.jl/blob/master/.buildkite/pipeline.yml too? Relatedly, should we modify https://github.com/FluxML/Flux.jl/blob/master/.github/workflows/nightly-ci.yml to test on pre instead of nightly?

remove v0.13 deprecations

reinsert optimisers

add 1.9 CI

drop julia v1.9
@CarloLucibello
Copy link
Member Author

I kept nightly since the pre is equivalent to 1.11 right now, but we can switch to pre when 1.12rc1 is out

@CarloLucibello
Copy link
Member Author

ready to go!

@CarloLucibello CarloLucibello merged commit 186b3bd into master Oct 12, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants