Fix ConvTranspose output padding on AMDGPU #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxl-th
reviewed
Jul 27, 2024
pxl-th
reviewed
Jul 27, 2024
pxl-th
approved these changes
Jul 27, 2024
This commit applies the output padding for ConvTranspose layers on
AMDGPU devices. Tests are added that ensure the output size is identical
to a ConvTranspose layer on the CPU.
In addition, this fixes the following test failure on AMDGPU:
Convolution: Error During Test at /var/lib/buildkite-agent/builds/amdgpu1-luraess-com/julialang/flux-dot-jl/test/ext_amdgpu/basic.jl:27
Got exception outside of a @test
MethodError: no method matching ConvTranspose(::typeof(identity), ::ROCArray{Float32, 3, AMDGPU.Runtime.Mem.HIPBuffer}, ::ROCArray{Float32, 1, AMDGPU.Runtime.Mem.HIPBuffer}, ::Tuple{Int64}, ::Tuple{Int64, Int64}, ::Tuple{Int64}, ::Int64)
paulnovo
force-pushed
the
fix-convtranspose-outpad-amd
branch
from
1568085
to
eba195b
Compare
Thank you for the feedback, I added your suggestions and squashed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies the output padding for ConvTranspose layers on AMDGPU devices. Tests are added that ensure the output size is identical to a ConvTranspose layer on the CPU.
In addition, this fixes the following test failure on AMDGPU:
PR Checklist