Fix function _size_check()
#2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxl-th
reviewed
Jul 28, 2024
pxl-th
approved these changes
Jul 28, 2024
Co-authored-by: Anton Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check
d > 0and the corresponding error message didn't make sense ifdwas the dimension to be checked. It would make sense to check that the difference between the available number of dimensions and the desired dimension is greater than or equal to zero, i.e.,ndims(x) - d >= 0ord <= ndims()respectively.Moreover, checking for
d > 0is rather pointless, since all implemented checks setd > 0.A corrected implementation is provided in this PR, which should fix this issue.