Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move enzyme to extension #2467

Merged
merged 5 commits into from
Jul 10, 2024
Merged

move enzyme to extension #2467

merged 5 commits into from
Jul 10, 2024

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Jun 30, 2024

[Edit: the method of train! added in #2446 need only be defined when the user loads Enzyme.jl]

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done. Looks good assuming tests pass.

@darsnack
Copy link
Member

It would be nice to clean up the test organization a bit, but that can be done in another PR

test/ext_enzyme/enzyme.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/train.jl Outdated Show resolved Hide resolved
@mcabbott mcabbott merged commit 8c15898 into master Jul 10, 2024
6 of 9 checks passed
@mcabbott mcabbott deleted the cl/enzyme2 branch July 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants