RNN deprecations and naming fixes #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename initial state weights to state0 add 1d & 2D input RNN BPTT gradient test
|
Could you add a TODO remove in v0.13comment in those getproperty? |
Done |
|
thanks! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #1367
This PR brings the disambiguation between initial state parameters named
state0in the rnn cells with the state of the rnn chain namedstatein theRecurstruct.Add getproperty with deprecation messages to access the legacy
handcin the rnn cells as well as theinitfield inRecu(which now points torecur.cell.state0).Include both 1D and 2D input dimensions to the basic BPTT test.