Fix PHP8 Memory leak

FluentDevelopment · Aug 21, 2020 · 79597c0 · 79597c0
1 parent 020c7f8
commit 79597c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ This version supports PHP7
 - 7.2
 - 7.3
 - 7.4
-- nightly
+- 8.0beta2
 
 # Installation
 ```

diff --git a/extension/xhprof.c b/extension/xhprof.c
@@ -1521,7 +1521,8 @@ zend_string *hp_trace_callback_curl_exec(zend_string *symbol, zend_execute_data
 #else
     if (arg == NULL || Z_TYPE_P(arg) != IS_OBJECT) {
 #endif
-        return symbol;
+        result = strpprintf(0, "%s", ZSTR_VAL(symbol));
+        return result;
     }
 
     zval params[1];
@@ -1555,6 +1556,7 @@ zend_string *hp_trace_callback_curl_exec(zend_string *symbol, zend_execute_data
 
     zval_ptr_dtor(&func);
     zval_ptr_dtor(&retval);
+    zval_ptr_dtor(&params);
 
     return result;
 }