Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cancel of queued job #43

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Allow cancel of queued job #43

merged 5 commits into from
Jul 11, 2023

Conversation

hlubek
Copy link
Member

@hlubek hlubek commented Jul 11, 2023

Fixes #40

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading, from my not existing Go knowledge :)

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (4863774) 70.68% compared to head (3642685) 71.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   70.68%   71.03%   +0.35%     
==========================================
  Files          20       20              
  Lines        2180     2196      +16     
==========================================
+ Hits         1541     1560      +19     
+ Misses        519      517       -2     
+ Partials      120      119       -1     
Impacted Files Coverage Δ
prunner.go 81.65% <100.00%> (+0.73%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hlubek
Copy link
Member Author

hlubek commented Jul 11, 2023

Looks good by reading, from my not existing Go knowledge :)

TIL concurrency is still hard...

Good that the race detector and coverage (???) showed some flaws - which was not only the test code. It should work based on the tests and some experiments locally with the UI (which also needs a small PR), so I'd draft a release candidate that we could test.

@hlubek hlubek merged commit 0313561 into main Jul 11, 2023
7 checks passed
@ahaeslich ahaeslich deleted the 40-allow-queued-job-cancel branch November 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: cancel queued job executions
2 participants