-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rate Limit details #158
Conversation
helm/flowforge/values.yaml
Outdated
enabled: false | ||
global: true | ||
max: 1000 | ||
maxAnonymous: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxAnonymous: 10 |
According to our defaults and docs, this should not be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps it could be undefined
if it needs to be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having it as an example value in the flowforge.yml STRONGLY implies it is the default value. If that is not the case then it needs be updated.
Also it's not clear, is this a fastify-rate-limit value or something you've added?
@hardillb. approved. However I will not merge any of these - I will leave merging for you to coordinate appropriately. |
part of FlowFuse/flowfuse#2530
Description
Allow rate limiting to be enabled
Related Issue(s)
FlowFuse/flowfuse#2530
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label