Eurocorp styled main menu

[xtruan]

What's new

• Added Eurocorp cyberpunk main menu inspired by this: http://syndicate.lubiki.pl/swars/gallery/swars_photos_inmenu_pc.php
• Exposed 3 more fonts from u8g2 via canvas (including newly added Eurocorp font)
  • This seems safe enough, but I might be missing something. Main concern is that if it's so easy to do, and the fonts are already there, why doesn't OFW or any CFW provide more font options...

---

For the reviewer

• I've uploaded the firmware with this patch to a device and verified its functionality
• I've confirmed the bug to be fixed / feature to be stable

[Willy-JL]

Main concern is that if it's so easy to do, and the fonts are already there, why doesn't OFW or any CFW provide more font options...

OFW doesn't because they don't care. We are welcome to add new ones when / if needed / wanted. The battery percent font for example is not in OFW, and for apps that ended up in the app catalog which used it, they added a define check for FW_ORIGIN_Official. Since unleashed doesn't have these new ones, this approach you did with canvas seems the smarter way. Only other concern might be firmware blob size... I haven't tried to look at whether the large collection of u8g2 fonts in that file are actually already built into the firmware, or if adding them this way is adding additional size to it (the eurocorp one of course does, I'm talking about letting other default ones be usable in canvas).

Code for menu looks fine, thanks! Only thing I would do is move the font setting out of the loop since it doesn't change, while the color setting is fine since you're always changing it between iterations due to the middle selected row.

[xtruan]

• Thanks for the feedback!
• That's good insight on what OFW is (or rather isn't) doing.
• I can't imagine all those u8g2 fonts are compiled in, I feel like the compiler is optimizing them out with the options that are set. Could be wrong though, if I get some time I'll do a bit of testing.
• I made the change you mentioned.

[Willy-JL]

LGTM!