Assets UI pagination

[joshuaunity]

Description

Added pagination to the asset table under the account detail page

Look & Feel

How to test

1. Vist the accounts page: Link
2. Click on an accounts with assets

Further Improvements

Bug with icons not displaying for assets in all assets tables

Related Items

This PR resolves the issue #1201

---

• I agree to contribute to the project under Apache 2 License.
• To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

[joshuaunity]

For the changelog do I add it under New features? since this is not really a new feature.

@nhoening @Flix6x

[nhoening]

I think it is a small new feature :)

[nhoening]

I see all tests passing!

…

On October 3, 2024 1:31:00 PM GMT+02:00, JDev ***@***.***> wrote: @nhoening @Flix6x do you have any idea what the failed test means? Its not pointing to the part of the code that may have an issue. -- Reply to this email directly or view it on GitHub: #1202 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[joshuaunity]

I think it is a small new feature :)

ok, so I go ahead to add it under features?

[nhoening]

I think it is a small new feature :)

ok, so I go ahead to add it under features?

Yes

[joshuaunity]

I think it is a small new feature :)

ok, so I go ahead to add it under features?

Yes

I've added the log 👍

[nhoening]

It works technically!

Two larger things:

1. You have not replaced the expensive server-side part yet:

The previous loading of all the assets (happening backend-side, here, both lines 56 and 57) still happens, so get rid of that please. No need for the CRUD endpoint to return assets.

2. Including public assets

Here is the dilemma I found:

We included public assets (where account_idis None) in this table before, and maybe that is why you used all_accessible=true. Indeed, the asset index API endpoint is not equipped to return assets from an account and the public ones in the same response.

Our options:

• Show two separate tables (for account assets and the public ones). Only the former would be paginated, however, and the second one might also be large.
• Do it like the backend did, and call the asset index twice, for each set separately, then merge the result. However, this doesn't work with pagination.
• Adapt the index endpoint to be able to add public assets separately. We'd add a parameter called include_public (defaults to False). Line 161 in the asset API would then happen if all_accessible is True or if include_public is True. Also adapt the docstring, of course.

I propose to do the third option.

P.S. As a user, I'd try to limit the search to PUBLIC assets only, by typing "PUBLIC" in the search box, but that isn't working. Maybe query_assets_by_search_terms() could accept that special case to then include public assets? It could add another query for public assets in the union_all if PUBLIC in search_terms.