This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Project standardization, fixes and CI #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no "val" column on "tf2idb_qualities", assumed "value".
Closed
|
Nice. I'll pull this in as soon as I have a chance to; gotta doublecheck it plays nicely with some changes I made. |
FlaminSarge
suggested changes
Jan 30, 2017
scripting/include/tf2idb.inc
Outdated
| * @return A fully executed DBStatement handle, or INVALID_HANDLE if the statement | ||
| * execution failed. This handle must be closed by the calling plugin, even though it is owned by tf2idb. | ||
| **/ | ||
| native DBStatement TF2IDB_CustomQuery(const char[] query, Handle arguments, int maxStringSize); |
scripting/include/tf2idb.inc
Outdated
| native Handle TF2IDB_ListParticles(); | ||
|
|
||
| //TF2IDB_FindItemCustom returns an Array Handle containing a list of integers for the first column of the query result | ||
| native Handle TF2IDB_FindItemCustom(const char[] query); |
scripting/include/tf2idb.inc
Outdated
| native int TF2IDB_GetItemAttributes(int id, int aid[TF2IDB_MAX_ATTRIBUTES], float values[TF2IDB_MAX_ATTRIBUTES]); | ||
|
|
||
| //TF2IDB_GetItemEquipRegions returns an Array Handle containing a list of the equip region names for the item | ||
| native Handle TF2IDB_GetItemEquipRegions(int id); |
There was a problem hiding this comment.
Should probably use ArrayList instead of Handle
|
|
||
| public void OnPluginStart() { | ||
| if (!TF2II_IsItemSchemaPrecached()) return; | ||
| Handle kv = TF2II_GetAttribKeyValues( 694 ); |
There was a problem hiding this comment.
you can't downcast Handle to KeyValues, but I could add a view_as if necesary
scripting/include/tf2idb.inc
Outdated
| native bool TF2IDB_DoRegionsConflict(const char[] region1, const char[] region2); | ||
|
|
||
| //TF2IDB_ListParticles returns an Array Handle containing a list of the particle IDs | ||
| native Handle TF2IDB_ListParticles(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported all the project to trasitional syntax, fixed some typos and added a travis-ci script.