Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Script to Calculate Summary Information for Benchmark Results #271

Merged
merged 28 commits into from
Nov 4, 2024

Conversation

kiddyjinjin
Copy link
Collaborator

Purpose

This PR introduces a new script to calculate summary information for benchmark results, aimed at providing insights into the average speedup for each operation categorized by data type.

Changes Made

  • Added a new script summary_for_plot.py that processes benchmark log files.
  • Implemented functionality to calculate and display average speedups for different data types.
  • Included conditional logic to handle query mode and provide backward compatibility notices.

Usage

To generate summary information from benchmark logs, run the following command:

python summary_for_plot.py path_to_your_log_file.log

Copy link
Collaborator

@StrongSpoon StrongSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a shell script to ensure the order of operator benchmarks.

tongxin
tongxin previously approved these changes Nov 2, 2024
Copy link
Contributor

@tongxin tongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But can we also show speedups over input sizes?

@kiddyjinjin
Copy link
Collaborator Author

I suggest adding a shell script to ensure the order of operator benchmarks.

Since the command for generating benchmarks is quite flexible (it might specify op_name, a specific file, or simply run all operations without any specification), it would be challenging to pre-sort the operations to be benchmarked. However, sorting the operations in the benchmark results after the run is a great suggestion.

Copy link
Collaborator

@StrongSpoon StrongSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiddyjinjin kiddyjinjin merged commit af0a3a6 into FlagOpen:master Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants