Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Operator] Add repeat op #195

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Operator] Add repeat op #195

merged 1 commit into from
Sep 4, 2024

Conversation

zfu82
Copy link
Collaborator

@zfu82 zfu82 commented Aug 30, 2024 •
edited by tongxin
Loading

PR Category

Operator

Type of Change

New Feature

Description

Add repeat op.

Issue

similar to #148

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

Tested on NV-A100
image

@zfu82 zfu82 requested a review from iclementine August 30, 2024 08:38
Bowen12992
Bowen12992 reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@Bowen12992 Bowen12992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where to put the codegen file and why the the test does not coverage the repeat.py file

@zfu82
Copy link
Collaborator Author

zfu82 commented Sep 2, 2024

Where to put the codegen file and why the the test does not coverage the repeat.py file

done

iclementine
iclementine previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though repeat is very close to tile, except that the len of repeats cannot be less than the ndim of the input tensor.

@zfu82 zfu82 closed this Sep 4, 2024
@zfu82 zfu82 reopened this Sep 4, 2024
@zfu82 zfu82 merged commit 5cead52 into master Sep 4, 2024
3 of 4 checks passed
@zfu82 zfu82 deleted the dev_repeat branch September 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowen12992 Bowen12992 Bowen12992 left review comments

@iclementine iclementine iclementine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zfu82 @iclementine @Bowen12992