Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Element Send Keys according to spec #33

Merged
merged 21 commits into from
May 8, 2024
Merged

Implement Element Send Keys according to spec #33

merged 21 commits into from
May 8, 2024

Commits on May 3, 2024

  1. Added failing SendKeys test.

    @grokys
    grokys committed May 3, 2024
    Configuration menu
    Copy the full SHA
    aa7f155 View commit details
    Browse the repository at this point in the history

  2. Extracted dispatching of actions to separate class.

    @grokys
    grokys committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7f5eb7d View commit details
    Browse the repository at this point in the history

  3. Initial impl of SendKeys according to spec.

    @grokys
    grokys committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5da0a69 View commit details
    Browse the repository at this point in the history

  4. Added failing SendKeys test.

    @grokys
    grokys committed May 3, 2024
    Configuration menu
    Copy the full SHA
    862efbe View commit details
    Browse the repository at this point in the history

  5. Fix some issues with key actions. 

    - The spec is unclear on how to tell if a cluster is a modifier. Maybe normalizing the cluster is the right thing to do, maybe it's not
- Add the input ID to the action sequence
    @grokys
    grokys committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cc56b4c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Add a delay after each key press. 

    Makes tests pass more consistently. There is probably a better way to do this.
    @grokys
    grokys committed May 5, 2024
    Configuration menu
    Copy the full SHA
    60b660b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Add a cancel action for keyDown action.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    89786b8 View commit details
    Browse the repository at this point in the history

  2. Assert input cancel list is empty according to spec.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d0636b2 View commit details
    Browse the repository at this point in the history

  3. Add a failing test due to w3c spec issue. 

    As far as I can see this failing test is caused by a defect in the spec w3c/webdriver#1809?
    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    df3bba1 View commit details
    Browse the repository at this point in the history

  4. Fix suspected issue in w3c spec.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5a46a0e View commit details
    Browse the repository at this point in the history

  5. Tidy up and ignore failing test.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2234e9b View commit details
    Browse the repository at this point in the history

  6. Fix input source types.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    01dee05 View commit details
    Browse the repository at this point in the history

  7. We only support key input sources currently.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9844248 View commit details
    Browse the repository at this point in the history

  8. Fix test naming. 

    Co-authored-by: aristotelos <[email protected]>
    @grokys @aristotelos
    grokys and aristotelos authored May 6, 2024
    Configuration menu
    Copy the full SHA
    483633c View commit details
    Browse the repository at this point in the history

  9. Remove debug code from test.

    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    82bff21 View commit details
    Browse the repository at this point in the history

  10. Guessing how things should be implemented. 

    Because the spec doesn't explain...
    @grokys
    grokys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    537e42f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Added a note about deviation from spec.

    @grokys
    grokys committed May 7, 2024
    Configuration menu
    Copy the full SHA
    27c7fbf View commit details
    Browse the repository at this point in the history

  2. Clear the input state map on reset.

    @grokys
    grokys committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b48fdd6 View commit details
    Browse the repository at this point in the history

  3. Use const for key constants.

    @grokys
    grokys committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9c8bc51 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Remove code that doesn't follow spec. 

    Looks like `ResetInputState` must be called manually to clean up?
    @grokys
    grokys committed May 8, 2024
    Configuration menu
    Copy the full SHA
    81d7a40 View commit details
    Browse the repository at this point in the history

  2. Use input cancel list instead of undo actions. 

    See w3c/webdriver#1809.
    @grokys
    grokys committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7188f38 View commit details
    Browse the repository at this point in the history