-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2910 Make Base implement IScopedNode - phase 1 #2913
Open
Kasdejong
wants to merge
30
commits into
develop-6.0
Choose a base branch
from
spike/make-resource-implement-iscopednode
base: develop-6.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
30fa951
Folded PocoElementNode into Resource
ewoutkramer d9bcf37
Merge branch 'develop-6.0' into spike/make-resource-implement-itypede…
ewoutkramer 061a0fd
WIP voor Kas
ewoutkramer 2bc3152
wip
Kasdejong a35a365
Removed ElementNode from Base
Kasdejong 6847fc2
Removed ElementNode from Base
Kasdejong 13f4286
Merge remote-tracking branch 'origin/spike/make-resource-implement-is…
Kasdejong 80ec690
small oversight here :)
Kasdejong a6e1eb5
trying this to fix the pipeline
Kasdejong e7e3dab
disable package validation
Kasdejong ac73de8
Fixed serializer again?
Kasdejong ce5b1e8
runs locally, let's see if it works on the pipeline?
Kasdejong 716f620
runs locally, let's see if it works on the pipeline?
Kasdejong 35379b4
Merge remote-tracking branch 'origin/spike/make-resource-implement-is…
Kasdejong c61fd46
why is this needed???????
Kasdejong 209e0be
Removed IBaseElementNavigator
Kasdejong 41e2ec5
Merge branch 'develop-6.0' into spike/remove-IBaseElementNavigator
Kasdejong 95cdbe8
defined IScopedNode (for now) and made base implement it.
Kasdejong 8454cbd
Merge branch 'spike/define-Iscopednode' into spike/remove-IBaseElemen…
Kasdejong a75232a
Merge branch 'develop-6.0' into spike/make-resource-implement-iscoped…
Kasdejong 06470cb
Revert "defined IScopedNode (for now) and made base implement it."
Kasdejong 451de22
removed pragmas
Kasdejong e8556e2
applied PR requested changes
Kasdejong 6142626
Merge pull request #2920 from FirelyTeam/spike/remove-IBaseElementNav…
ewoutkramer ab9f46b
updated compatibility suppressions
Kasdejong 10d91b3
Merge branch 'develop-6.0' into spike/make-resource-implement-iscoped…
Kasdejong 48b7f7b
removed unused imports after merge
Kasdejong f3f50fc
applied PR requested changes
Kasdejong c5dec88
applied PR requested changes
Kasdejong 34c4d0c
Merge remote-tracking branch 'origin/spike/make-resource-implement-is…
Kasdejong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction of IBaseElementNavigator made it necessary to make these public, I think they can be internal again - in any case the reference to IBaseElementNavigator in the Obsolete should be changed!