Improve support for more complex challenge management #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the retrieval and management of challenges.
From a good vibes perspective, this a) aligns the main interface name with the functionality it's intended to provide, and b) improves the interface segregation (hi, SOLID).
In terms of practical needs, this helps solve the (fairly rare) need of challenges that are managed as part of a broader external system. This could be a data model, microservice, or whatever. By splitting the interfaces and only requiring that the newer
ChallengeLoaderInterfacemake it to the verification processes, this becomes both easier and more testable.