Update credential storage #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
============================================
+ Coverage 82.90% 85.23% +2.33%
- Complexity 233 253 +20
============================================
Files 27 27
Lines 702 813 +111
============================================
+ Hits 582 693 +111
Misses 120 120 ☔ View full report in Codecov by Sentry. |
Merged
Firehed
added a commit
that referenced
this pull request
Nov 20, 2023
This is being pulled out of #53 to ease the storage of the attestation object without having to reinvent any data formats. Unused at this time.
Firehed
added a commit
that referenced
this pull request
Nov 21, 2023
This adds additional methods to the credential interface for tracking the [complete set of recommended data](https://www.w3.org/TR/webauthn-3/#reg-ceremony-store-credential-record) in the updated spec (§7.1¶27). This does NOT yet integrate the updated data into the storage tooling. As has been the trend recently, this is being pulled out of #53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAuthn Level 3 §7.1¶27 now makes an official recommendation as to what data should be persisted during credential registration. This prepares the credential object such that the library will be able to do so.