Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intermediate data structure for attested credential data #52

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Nov 19, 2023

Rather than having the AuthenticatorData build the Credential during registration, it's now being adjusted to instead return the underlying components that it will need.

While this is a minor structural formality right now, it will ease the adoption of the updated credential storage recommendations described in the Level 3 version of the spec that are not captured in the current L2-based implementation.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a0562be) 81.27% compared to head (f76b47f) 81.03%.

Files Patch % Lines
src/Attestations/FidoU2F.php 0.00% 3 Missing ⚠️
src/AttestedCredentialData.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
- Coverage     81.27%   81.03%   -0.24%     
- Complexity      207      208       +1     
============================================
  Files            24       25       +1     
  Lines           614      617       +3     
============================================
+ Hits            499      500       +1     
- Misses          115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit 8e7f191 into main Nov 19, 2023
8 of 10 checks passed
@Firehed Firehed deleted the acd-ds branch November 19, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant