Check new interface method, ensure fractional seconds are not lost

Firehed · Mar 2, 2024 · c9ab1aa · c9ab1aa
1 parent d600cce
commit c9ab1aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/ExpiringChallenge.php b/src/ExpiringChallenge.php
@@ -17,7 +17,7 @@
  *
  * @phpstan-type SerializationFormat array{
  *   c: string,
- *   e: int,
+ *   e: numeric-string,
  * }
  */
 class ExpiringChallenge implements ChallengeInterface
@@ -92,7 +92,7 @@ public function __serialize(): array
     {
         return [
             'c' => $this->wrapped->getBase64(),
-            'e' => $this->expiration->getTimestamp(),
+            'e' => $this->expiration->format('U.u'),
         ];
     }
 

diff --git a/tests/ChallengeInterfaceTestTrait.php b/tests/ChallengeInterfaceTestTrait.php
@@ -30,6 +30,11 @@ public function testSerializationRoundTrip(): void
             $unserialized->getBase64(),
             'Base64 changed',
         );
+
+        self::assertEquals(
+            $challenge->getExpiration(),
+            $unserialized->getExpiration(),
+        );
     }
 
     public function testBinaryMatchesBase64(): void