Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated README note #382

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Remove outdated README note #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,6 @@ metrics.instrument(res, { as: 'express.http.res' });
The first argument is the object you want to instrument, and the second
argument specifies what type of object it is.

## Note about unit tests and Node v6.x

The unit tests must be run under Node v6.x.x due to the dev dependency of
`[email protected]` which doesn't work on newer versions of Node. The unit tests that
depend on `mitm` need rewriting if we want to use a newer version of `mitm`.

Related `next-metrics` issue: [mitm pinned to 1.2.0 due to failing tests (#111)](https://github.com/Financial-Times/next-metrics/issues/111)

## Metrics

Data is logged in the form of Graphite keys (dots denote hierarchy):
Expand Down