Merge pull request #30 from Financial-Times/aintgoin2goa-patch-1

Single line stacktrace
Financial-Times · Sep 13, 2016 · 90fcea7 · 90fcea7
2 parents 94d235d + 38630c1
commit 90fcea7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/lib/format.js b/src/lib/format.js
@@ -4,7 +4,8 @@ const extractErrorDetails = err => {
 		error_name: err.name
 	};
 	if (err.stack) {
-		deets.error_stack = err.stack;
+		// logs need to all be on one line, so remove newlines from the stacktrace
+		deets.error_stack = err.stack.replace(/\n/g, '; ');
 	}
 
 	return deets;

diff --git a/test/logger.test.js b/test/logger.test.js
@@ -59,7 +59,7 @@ describe('Logger', () => {
 			logger.log('info', new MyError('whoops!'));
 			logSpy.lastCall.args[1].should.have.property('error_message', 'whoops!');
 			logSpy.lastCall.args[1].should.have.property('error_name', 'Error');
-			logSpy.lastCall.args[1].error_stack.should.startWith('Error: whoops!\n    at');
+			logSpy.lastCall.args[1].error_stack.should.startWith('Error: whoops!;     at');
 		});
 
 		it('should combine Error message meta', () => {