MakiePlotter rewrite with ShaderAbstractions.Buffer

[koehlerson]

Change

• MakiePlotter caches now by creation a GeometryBasics.Mesh
  • the underlying mesh uses ShaderAbstractions.Buffer for the triangles and positions
• a copy of all triangles and the triangle coords without displacement is within the plotter
• Made a few recipes more readible by getting rid of ternary operators and used begin end instead

Needed Makie PRs

• don't convert if not necessary MakieOrg/Makie.jl#2765
• fix #2767 and #1881 (slow data_limits for recipes) MakieOrg/Makie.jl#2770
• preserve Buffer by not using decompose MakieOrg/Makie.jl#2774

Removed functions

• facedofs
• FerriteViz.to_triangles
• visible

Timings

solutionplot

Makie version	FerriteViz version	plasticity	incompressible-elasticity	heat-3D-70^3
master	mk/buffer 817048d	17.866 ms (50939 allocations: 3.92 MiB)	31.648 ms (98402 allocations: 7.66 MiB)	6.100 s (38224 allocations: 1.20 GiB)
master	mk/buffer ece12d9	17.272 ms (84065 allocations: 6.96 MiB)	40.331 ms (218408 allocations: 22.30 MiB)	8.397 s (4152021 allocations: 1.69 GiB)
master	master	19.213 ms (101569 allocations: 8.10 MiB)	47.713 ms (317502 allocations: 28.85 MiB)	15.122 s (11007449 allocations: 2.34 GiB)
v0.19.2	master	28.692 ms (374363 allocations: 21.19 MiB)	56.697 ms (557250 allocations: 40.28 MiB)	70.740 s (603707659 allocations: 29.94 GiB)

[koehlerson]

remaining big alloc problem for 70^3 elements in heat equation example:

julia> mesh = GeometryBasics.Mesh(collect(plotter.physical_coords),collect(plotter.vis_triangles));

julia> @btime GLMakie.mesh(mesh)
  456.759 ms (33435 allocations: 2.32 MiB)

julia> @btime GLMakie.mesh(plotter.mesh)
  829.511 ms (33447 allocations: 755.98 MiB)

julia> typeof(mesh)
GeometryBasics.Mesh{3, Float32, GeometryBasics.Ngon{3, Float32, 3, GeometryBasics.Point{3, Float32}}, GeometryBasics.SimpleFaceView{3, Float32, 3, GeometryBasics.OffsetInteger{-1, UInt32}, GeometryBasics.Point{3, Float32}, GeometryBasics.NgonFace{3, GeometryBasics.OffsetInteger{-1, UInt32}}}}

julia> typeof(plotter.mesh)
GeometryBasics.Mesh{3, Float32, GeometryBasics.Ngon{3, Float32, 3, GeometryBasics.Point{3, Float32}}, GeometryBasics.FaceView{GeometryBasics.Ngon{3, Float32, 3, GeometryBasics.Point{3, Float32}}, GeometryBasics.Point{3, Float32}, GeometryBasics.NgonFace{3, GeometryBasics.OffsetInteger{-1, UInt32}}, ShaderAbstractions.Buffer{GeometryBasics.Point{3, Float32}, Vector{GeometryBasics.Point{3, Float32}}}, ShaderAbstractions.Buffer{GeometryBasics.NgonFace{3, GeometryBasics.OffsetInteger{-1, UInt32}}, Vector{GeometryBasics.NgonFace{3, GeometryBasics.OffsetInteger{-1, UInt32}}}}}}

[termi-official]

Does pprof expose something useful?

[koehlerson]

Does pprof expose something useful?

Haven't checked it yet, Todo for next week maybe

[termi-official]

LGTM otherwise.