Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Conditional posting via favourites #109

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xurizaemon
Copy link

@xurizaemon xurizaemon commented Mar 11, 2019

Rather than requiring the user to include a hashtag to set conditional cross-posting (which I don't like because the user then has to mention other, less cool networks when posting, sullying their carefully crafted toots with unsightly metadata), this empowers moa.party users to opt into post relaying by tapping the ⭐ button, which is empowering and excellent UX.

See #108.

I'm testing this myself, it's WIP and I hope @foozmeat (and you!) will give some input on improving it.

Todo:

  • Correctly rename the migration changes.
  • Rename existing conditional_posting column (to conditional_posting_hashtags?) for less confusion.
  • Instagram support also (they have faves, right?)

I don't know the correct way to reserve a migration ID, so I've named
this `abcdef012345`. Guidance welcome.

Also I expect to rename the existing `conditional_posting` storage,
because it will be confusingly named if this new conditional posting
method is added.
And fix behaviour for conditional toot relaying also.
@foozmeat
Copy link
Contributor

@xurizaemon Thanks for this PR! I think one tricky thing about this is that a person has between 0 and 300 seconds in order to fav their message. In other words they might easily miss the window to fav. There may be a way to delay the processing of messages if you have this option enabled.

@xurizaemon
Copy link
Author

xurizaemon commented Mar 12, 2019

👋 thanks!

Yeah, I'm aware of the time window to fave - for me, that works OK, since the clients I use for Twitter and Mastodon make it straightforward to fave straight away. But it is a bit of a UX trick, and unpredictable if you're at the 0s end of things 😁

Doing otherwise would probably require more effort to track recent faves as well as recent statuses, and I don't think that's essential.

300s - is that the frequency the worker task is run at, or some other time window in moa that I didn't spot yet?

@foozmeat
Copy link
Contributor

Yeah I run 5 workers each every 5 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants