-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about #670 #672
Conversation
@k163377 Yes, this looks good to me. In addition, it'd be good to add something on 2.15 Wiki release notes here: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15#changes-compatibility (in whichever section makes most sense) I try to keep these updated based on findings, things users report; so even if not initially included on actual release it should have complete set of information we have. |
@cowtowncoder |
I sent you an invite, that should give access to this wiki and |
@cowtowncoder |
Can I suggest this instead: jackson-module-kotlin changes the serialization result of getter-like functions starting with 'is'. For example, a function defined as The term 'regression' implies that we will change the behaviour back to what it was before - that we are accepting it as a bug that needs to be fixed. Documenting it in the release notes then implies the opposite - that we are keeping the change. So, I think we should not use the word 'regression' here. |
@pjfanning I am very sorry, but would you be able to help me with PR? |
@k163377 I modified the wiki. If anyone feels like my changes are inaccurate, feel free to further edit them. |
Changed wording based on comments in #672
@pjfanning I have submitted a PR regarding the release note. |
Thank you @k163377 and @pjfanning ! Good point on semantics of regression: using optimal term helps avoid misunderstanding by users. |
Added note regarding disruptive changes reported in #670.
@cowtowncoder
Is this an appropriate way to write annotations in such cases?
Please let me know if it should be reflected outside of the release notes.