Issue #356 Demangling kotlin getter

[dinomite]

Fixes issue found in #356, serialization of inline classes, using @elektro-wolle's contribution.

[dinomite]

@cowtowncoder Are there performance considerations around this or tests I should run in that respect?

[efenderbosch]

Might want to add:

a.declaringClass.methods.any { it.name == "box-impl" }

to ensure that this is an inline class. Or declaredMethods. I always forget which is which.

[dinomite]

Hmm, I don't see any methods with box-impl. The documentation on name mangling doesn't mention that name, but an earlier KEEP does. Do we need another unit test to show this behavior?

[cowtowncoder]

One problem with this approach: findNameForSerialization() should ONLY be used if there is explicit annotation (like @JsonProperty) as it will force name -- so override here could prevent use of explicit annotations.

This could be resolved by instead overriding findImplicitPropertyName() which is intended for name mangling of "implicit" name (one derived from accessors).

But it might be even better to use 2.12 introduced AccessorNamingStrategy, added via:

FasterXML/jackson-databind#2800

as this would open up much more efficient handling of all aspects of naming for a class -- a strategy instance is created (via .Provider) for given AnnotatedClass and can do pre-processing for a set of names (or at least hold on to a preference).

But perhaps the simplest way for now would be overriding findImplicitPropertyName(), and maybe considering bigger rewrite for 2.13.

[dinomite]

@cowtowncoder Moved the checking to findImplicitPropertyName() and filed an issue for using AccessorNamingStrategy in the future (slated for 2.13.0 right now…hopefully I'll have enough knowledge to do it at that point).

[dinomite]

@elektro-wolle Would you sign the CLA for Jackson and email a scan/photo of the result to info at fasterxml dot com?

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

[cowtowncoder]

@dinomite That sounds like a good approach to me.

[elektro-wolle]

@dinomite

@elektro-wolle Would you sign the CLA for Jackson and email a scan/photo of the result to info at fasterxml dot com?

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

Unfortunately, your gmail settings rejects the mail from my mailserver to your mail-address: rejected due to spam classification. The owner of the group can choose to enable message moderation instead of bouncing these emails. More information can be found here: https://support.google.com/a/answer/168383.

[dinomite]

Hmm, maybe there is something @cowtowncoder, but you can also just send it to me (drew@[my github username].net) and I'll get it on to Tatu.

[efenderbosch]

Looks like this didn't make it in to 2.12? Just tried updating our Kotlin 1.4 branch to 2.12 and the getters are still mangled.

[dinomite]

@efenderbosch Yes, I still need a CLA from @elektro-wolle

[elektro-wolle]

@dinomite I've just resent the CLA to your address.

[dinomite]

Got the CLA and forwarded to Tatu. I'll get this merged today.