-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jackson-3] Address #493, disable DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES
by default.
#4625
Conversation
src/main/java/tools/jackson/databind/DeserializationFeature.java
Outdated
Show resolved
Hide resolved
@JooHyukKim Looks good, only had 1 comment that I added. I can change that & update release notes and then merge this. |
Merged. Thank you @JooHyukKim ! |
@JooHyukKim Could you update JSTEP-2 page with change? I updated README, release-notes wiki. |
Done 👍🏼 |
@JooHyukKim I think this broke a few tests in downstream packages (dataformats (binary, text, xml), jackson-modules-base etc). The reason it was not obvious was because snapshot builds started failing for 3.x few weeks ago -- I think api token I used got disabled for some reason. I created new one, assigned as secret, and snapshot deploys work again... and now breakage is obvious. F.ex:
|
Fixed Failing:
(and possibly others but these at least) |
|
I wonder there is a way to alert cascading-build failure back to databind 🤔 |
@JooHyukKim in theory, there probably would be a way (cascading rebuild case could take some action). But for now email notifications probably need to suffice, as long as they get triggered. Although the problem here was not cascading part but snapshot deploy: both since new snapshot version was not made available and since this prevent cascading builds themselves (but without snapshot deploy they wouldn't have found issues either). |
Ok so XML and text-formats fixed. Aside from binary-formats, Scala, 2 more failures:
|
addresses #493
Note
Once merged, JStep-2 Wiki should be updated.