Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2482 #2616

Closed
wants to merge 2 commits into from
Closed

Fix #2482 #2616

wants to merge 2 commits into from

Conversation

istudens
Copy link
Contributor

@istudens istudens commented Feb 4, 2020

A backport of #2482 to 2.9 branch.

Thanks.

@cowtowncoder
Copy link
Member

Thanks -- it is unlikely there will be new 2.9 minor releases, but I guess this seems like safe enough change for patch, as micro-patches of databind are likely (due to polymorphism CVEs).

@cowtowncoder
Copy link
Member

Oh. Actually... No. Since type of exception changes, I think I don't want to merge this in, unfortunately.
While it should be fine for most users I think it is possible some users might catch specific exception subtype; and due to 2.9 branch being so far with patches I want to minimize any chance of regression.

So, thank you for submitting this, but I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants