Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split most of Factory out to FactoryLib #443

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

BenSparksCode
Copy link
Contributor

@BenSparksCode BenSparksCode commented Oct 19, 2024

Changes:

  • In order to cut down Atlas contract size, we've started the contract splitting with Factory.
  • Atlas is used as the endpoint contract for a lot of the external Factory functions in tests and testnet deployments, so these have been left in Factory, as well as the internal functions called inside Atlas. The salt calculation function has also be left in Atlas.
  • The rest of the factory logic as been moved to FactoryLib, a new contract which is delegatecalled by Factory. FactoryLib must be explicitly deployed separately and configured as a constructor param in Atlas.
  • This results in a 524 bytes decrease in contract size.

@BenSparksCode BenSparksCode marked this pull request as ready for review October 21, 2024 19:10
@BenSparksCode BenSparksCode merged commit 1227ba6 into size-cuts Oct 21, 2024
3 checks passed
@BenSparksCode BenSparksCode deleted the factory-lib-deployed branch October 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant