-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: improve MinariDataset #102
ENH: improve MinariDataset #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to run fine and produces a performant policy, I requested a few minor changes, and asked a few questions.
One more comment: It might be good to provide a requirements.txt for tutorials(though the version of Minari this will depend on isn't in a release yet, so I suppose it would have to be in a later PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor change requests, and a reminder that we should add a version locked requirements.txt after the next minari release. Otherwise, looks good, and ready to merge, assuming 500 is a good amount of total reward for the final cloned policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :^)
Looks good! Ready to merge |
Description
Add
__getitem__
and__len__()
toMinariDataset
and few refactors.Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.