More Main Menu Content #13759

Jade-Harleyy · 2024-04-10T04:59:27Z

This PR adds:

Buttons for the remaining content editors to the main menu.
Singleplayer mission/sandbox modes (latter accessible by selecting no available missions for the former).

New Localization Tags:

leveleditorbutton - Level Editor
particleeditorbutton - Particle Editor
eventeditorbutton - Event Editor
spriteeditorbutton - Sprite Editor
newmissionbutton - Start Mission

Modified Localization Tags:

campaignlabel - Campaign => Singleplayer
newgamebutton - New Game => New Campaign
loadgamebutton - Load Game => Load Campaign

Implement singleplayer mission and sandbox modes.

EebleSheembl · 2024-04-10T05:09:11Z

Need

PanmanS · 2024-04-10T06:47:07Z

This would significantly simplify testing for specific missions when quickstart doesnt suffice and serve lobby is too long to load

Regalis11 · 2024-04-10T10:48:44Z

Buttons for the remaining content editors to the main menu.

I don't think all of these should be included in the main menu. Many of them are not intended to be used the average player, but rather advanced modders who are expected to be able to access them using console commands. If we were to make them visible in the main menu, we would need to localize all the texts in them to all the languages the game supports, and preferably also make them a lot more user-friendly.

I also feel a little iffy about including the mission mode in the main menu like this. The mission mode is so underdeveloped that in my opinion it needs to be reworked before it's put into the spotlight like this.

NotWendy · 2024-04-11T06:15:01Z

When I was getting into the game around 1.0, I used the mission mode as a training tool, to understand the very basics of the game, in addition to doing some of the tutorials. It may be underdeveloped right now, but it still works well enough for that purpose, allowing a new player to learn the ropes and fail in a low stakes environment.
I understand you don't want players to get the wrong impression of what the mission mode is supposed to be by trying it out before its big overhaul happens. But with the value it already brings to the game, I think you can consider adding it to the main menu early.

WrillWasTaken · 2024-04-11T09:12:00Z

This would significantly simplify testing for specific missions when quickstart doesnt suffice and serve lobby is too long to load

wouldn't the better solution be to just add difficulty, bot count and biome to the quickstart command?

Regalis11

While the rest of the changes look good to me, I don't think we can merge this in it's current form

The "hidden editors" should not be included in the main menu. Many of them are not intended to be used the average player, but rather advanced modders who are expected to be able to access them using console commands. If we were to make them visible in the main menu, we would need to localize all the texts in them to all the languages the game supports, and preferably also make them a lot more user-friendly.

Regalis11

Probably shouldn't have said that the rest of the changes look good to me in the last review without taking a more in-depth look at the other code changes first. 😅 I'm also having second thoughts about how much sense it makes to add the mission mode option to the menu right now:

I'm still of the opinion that the mission mode is so underdeveloped it should not be put into spotlight like this in it's current state (first option in the main menu after the tutorials - I think a new player who assumes such a prominently displayed game mode is something they should start with would get a bad first impression of the game).

We have some plans for overhauling it in the future (some of which we're planning to do alongside the PvP overhaul), with things like options to select upgrades and extra supplies, and to select more than one mission per round. Those will most likely require quite a lot of changes to the "setup ui" and the code, so I feel it's not a good idea to include this sort of a "intermediate" version at this stage. But this PR could be of some use when we start looking into the mission mode overhaul, although I think it does still require some further work: I feel there's some code quality issues here, mainly a lot of copypasted, duplicate code, and dead code that does nothing.

Regalis11 · 2024-07-06T07:31:32Z

Barotrauma/BarotraumaClient/ClientSource/Screens/MainMenuScreen/MainMenuScreen.cs

+            LevelEditor = 11,
+            ParticleEditor = 12,
+            EventEditor = 13,
+            SpriteEditor = 14,


The above enums are unused

Regalis11 · 2024-07-06T07:31:45Z

Barotrauma/BarotraumaClient/ClientSource/Screens/MainMenuScreen/MainMenuScreen.cs

            };
+            */


Commented out code should be removed

Regalis11 · 2024-07-06T07:31:58Z

Barotrauma/BarotraumaClient/ClientSource/Screens/MainMenuScreen/MainMenuScreen.cs

+                    break;
+                case Tab.SpriteEditor:
+                    CoroutineManager.StartCoroutine(SelectScreenWithWaitCursor(GameMain.SpriteEditorScreen));
+                    break;


These are not (and should not be) used

Regalis11 · 2024-07-06T07:33:32Z

Barotrauma/BarotraumaClient/ClientSource/Screens/SinglePlayerMissionSetupUI.cs

+            }
+        }
+    }
+}


There is a huge amount of code duplication between this class and CampaignSetupUI. The shared logic should most likely be moved to a shared base class.

Regalis11 · 2024-07-06T07:34:29Z

Barotrauma/BarotraumaShared/SharedSource/Events/Missions/AbandonedOutpostMission.cs

+#if SERVER
+                        GameMain.Server?.EndGame();
+#else
+                        if (GameMain.GameSession.GameMode is { IsSinglePlayer: true } && GameMain.GameSession.CrewManager is { IsSinglePlayer: true })


I'm not sure I understand why IsSinglePlayer: true is checked on both the GameMode and the CrewManager. Is there a situation in which one is singleplayer, and the other isn't?

Fixed, it now only checks if the GameMode has IsSinglePlayer set. Also fixed in CoOpMode.cs.

Regalis11 · 2024-07-06T07:34:54Z

Barotrauma/BarotraumaShared/SharedSource/Events/Missions/AbandonedOutpostMission.cs

+#if SERVER
+                            GameMain.Server?.EndGame();
+#else
+                            if (GameMain.GameSession.GameMode is { IsSinglePlayer: true } && GameMain.GameSession.CrewManager is { IsSinglePlayer: true })


Same here, why does IsSinglePlayer: true need to be checked on both of these?

Fixed; see previous comment.

Regalis11 · 2024-07-06T07:35:51Z

Barotrauma/BarotraumaShared/SharedSource/GameSession/GameModes/CoOpMode.cs

+            {
+                End();
+            }
+        }


There is a ton of code duplication between this class and GameServer.cs which handles ending the round in multiplayer.

Regalis11 · 2024-07-06T07:36:05Z

Barotrauma/BarotraumaShared/SharedSource/GameSession/GameModes/CoOpMode.cs

        public CoOpMode(GameModePreset preset, IEnumerable<MissionPrefab> missionPrefabs) : base(preset, ValidateMissionPrefabs(missionPrefabs, MissionPrefab.CoOpMissionClasses)) { }

        public CoOpMode(GameModePreset preset, MissionType missionType, string seed) : base(preset, ValidateMissionType(missionType, MissionPrefab.CoOpMissionClasses), seed) { }
+
+#if CLIENT


It'd be better to move the client-specific code to a partial class.

Add buttons for all editors to the main menu.

f34d83e

Implement singleplayer mission and sandbox modes.

Cleanup.

9ea8b77

Regalis11 requested changes Jun 27, 2024

View reviewed changes

Regalis11 added Feature request Request a new feature to be added Code Programming task Waiting Cannot be worked on/reviewed/tested at the moment for some reason labels Jun 27, 2024

Jade-Harleyy and others added 2 commits July 4, 2024 18:30

Merge branch 'FakeFishGames:master' into moremainmenucontent

32cc8b7

Remove other editor buttons from main menu screen.

1f021ba

Jade-Harleyy requested a review from Regalis11 July 4, 2024 23:49

Regalis11 requested changes Jul 6, 2024

View reviewed changes

Jade-Harleyy added 2 commits July 7, 2024 19:59

Address some review comments.

38e323d

Add files.

c69ae30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More Main Menu Content #13759

More Main Menu Content #13759

Jade-Harleyy commented Apr 10, 2024 •

edited

Loading

EebleSheembl commented Apr 10, 2024

PanmanS commented Apr 10, 2024 •

edited

Loading

Regalis11 commented Apr 10, 2024

NotWendy commented Apr 11, 2024

WrillWasTaken commented Apr 11, 2024

Regalis11 left a comment

Regalis11 left a comment •

edited

Loading

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

Regalis11 Jul 6, 2024

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

Regalis11 Jul 6, 2024

Regalis11 Jul 6, 2024

Jade-Harleyy Jul 8, 2024

More Main Menu Content #13759

Are you sure you want to change the base?

More Main Menu Content #13759

Conversation

Jade-Harleyy commented Apr 10, 2024 • edited Loading

New Localization Tags:

Modified Localization Tags:

EebleSheembl commented Apr 10, 2024

PanmanS commented Apr 10, 2024 • edited Loading

Regalis11 commented Apr 10, 2024

NotWendy commented Apr 11, 2024

WrillWasTaken commented Apr 11, 2024

Regalis11 left a comment

Choose a reason for hiding this comment

Regalis11 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jade-Harleyy commented Apr 10, 2024 •

edited

Loading

PanmanS commented Apr 10, 2024 •

edited

Loading

Regalis11 left a comment •

edited

Loading