Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameter lastSlotId to slotCount #3968

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

viciscat
Copy link
Contributor

Changed lastSlotId to slotCount in the createAndAdd method of SlotRanges

The mapping made sense up until the enderchest where the method looked like this

createAndAdd(list, "enderchest.", 200, 27);

with 200 in firstSlotId and 27 in lastSlotId, which doesn't really make sense (unless you count integer overflows but I don't think that's the intended thing).
The code does a fori loop from 0 to lastSlotId and does firstSlotId + i. So I think slotCount is a pretty good name, size could work too.

@apple502j apple502j changed the base branch from 24w34a to 24w36a September 5, 2024 02:45
@apple502j apple502j merged commit 6d65f5c into FabricMC:24w36a Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants