Rename parameter lastSlotId to slotCount #3968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
lastSlotId
toslotCount
in thecreateAndAdd
method ofSlotRanges
The mapping made sense up until the enderchest where the method looked like this
with
200
infirstSlotId
and27
inlastSlotId
, which doesn't really make sense (unless you count integer overflows but I don't think that's the intended thing).The code does a
fori
loop from 0 tolastSlotId
and doesfirstSlotId + i
. So I thinkslotCount
is a pretty good name,size
could work too.