Correct very incorrect names in ServerScoreboard #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3850
The proposed names may bring up some concerns, so I'm gonna explain them here:
objectives->syncableObjectives: The original issue proposedsyncedObjectivesandvisibleObjectives.syncedObjectivescan sound like "objectives that are [already] synced", which is wrong (the field stores objectives whose changes will be synced with all clients)I discarded
visibleObjectivesbecause the main purpose of ServerScoreboard is to synchronize objectives with clients (what it does). How it chooses which objectives to synchronize is an implementation detailAs such, the methods were named
startSyncingandstopSyncingaccordingly, instead of, for example,markVisibleandunmarkVisible(which wouldn't mean anything)