-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v2 into v3 #501
Merged
Merge v2 into v3 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional information was introduced by accident in #376 when implementing #373 to add a timeout for generating values. Error messages in the preview (and other places) would contain the full name of the exception that caused the error, which is completely unnecessary. This fix was originally implemented in the `uds` branch, but I decided to add a "backports" branch for fixes I might want to release in a v2.x.x release before releasing v3.0.0.
Brings the v2 branch up-to-speed with updates from v3. Also adds my full email address and resolves some style errors. Basically a big deserved maintenance edit.
And fix some smaller issues in code here and there, which have already been fixed in the v3 branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 52 52
Lines 1993 1993
Branches 335 335
=======================================
Hits 1695 1695
Misses 235 235
Partials 63 63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489.
Doesn't actually contain any code changes. This is purely symbolic so I can tell myself v2 is finally over.