Use Kotlin UI DSL #470
Merged
Use Kotlin UI DSL #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs a lot of work in creating a consistent API, streamlining the API, documenting the API, and testing the API.
This entirely deprecates the class `VariableLabelRadioButton`.
The latter meaning that an empty label in a ComboBox is now no longer really used. What is still left to do, though, is to consider where the Affixes section can be replaced with a singular reusable "Surround with" option.
Recursive decorators are not something the user can choose to add, but instead it is a major small alteration of the existing code to allow decorators themselves to have decorators.
And reorganise some further UI elements.
(Though they are not necessarily valid.)
Tests still fail, but fewer than last time.
FWDekker
added
bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
+ Coverage 84.53% 85.54% +1.01%
==========================================
Files 52 50 -2
Lines 1862 1910 +48
Branches 342 322 -20
==========================================
+ Hits 1574 1634 +60
+ Misses 247 216 -31
- Partials 41 60 +19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, after many years, and after several months of hard work: Fixes #360.
Every since 2019, I tried every year to use JB's Kotlin UI DSL, but every time the API was either too immature or too different from the current design of Randomness. This year I decided to write my own API, but found that it was somewhat similar to v2 of JB's UI DSL, and so I decided to migrate to their DSL. Still, this required an enormous overhaul of how the entire UI worked, and this gigantic PR thus also includes several bug fixes, UI improvements, documentation changes, and many other improvements. For a time, this was the dev branch of the dev branch. Once the rewriting was done, many tests also had to be rewritten. With the exception of one class, all tests are now done using Kotest.