Improve detection of read-only files

Fixes #491.
FWDekker · Nov 12, 2023 · 27c9dec · 27c9dec
1 parent 64378e7
commit 27c9dec
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/main/kotlin/com/fwdekker/randomness/InsertAction.kt b/src/main/kotlin/com/fwdekker/randomness/InsertAction.kt
@@ -52,7 +52,7 @@ abstract class InsertAction(
         val presentation = event.presentation
         val editor = event.getData(CommonDataKeys.EDITOR)
 
-        presentation.isEnabled = editor != null
+        presentation.isEnabled = editor?.document?.isWritable == true
     }
 
     /**

diff --git a/src/main/kotlin/com/fwdekker/randomness/PopupAction.kt b/src/main/kotlin/com/fwdekker/randomness/PopupAction.kt
@@ -41,7 +41,7 @@ class PopupAction : AnAction(Icons.RANDOMNESS) {
         event.presentation.icon = Icons.RANDOMNESS
 
         // Running this in [actionPerformed] always sets it to `true`
-        isEditable = event.getData(CommonDataKeys.EDITOR)?.isViewer == false
+        isEditable = event.getData(CommonDataKeys.EDITOR)?.document?.isWritable == true
     }
 
     /**

diff --git a/src/test/kotlin/com/fwdekker/randomness/InsertActionTest.kt b/src/test/kotlin/com/fwdekker/randomness/InsertActionTest.kt
@@ -181,22 +181,29 @@ class InsertActionTest : BasePlatformTestCase() {
 
     fun `test that it disables the presentation if the editor is null`() {
         val presentation = Presentation()
-        val event = AnActionEvent.createFromDataContext("", presentation) { null }
 
-        insertAction.update(event)
+        insertAction.update(AnActionEvent.createFromDataContext("", presentation) { null })
 
         presentation.isEnabled shouldBe false
     }
 
     fun `test that it enables the presentation if the editor is not null`() {
         val presentation = Presentation()
-        val event = AnActionEvent.createFromDataContext("", presentation) { myFixture.editor }
 
-        insertAction.update(event)
+        insertAction.update(AnActionEvent.createFromDataContext("", presentation) { myFixture.editor })
 
         presentation.isEnabled shouldBe true
     }
 
+    fun `test that it disables the presentation if the editor is read-only`() {
+        val presentation = Presentation()
+
+        myFixture.editor.document.setReadOnly(true)
+        insertAction.update(AnActionEvent.createFromDataContext("", presentation) { myFixture.editor })
+
+        presentation.isEnabled shouldBe false
+    }
+
 
     /**
      * Moves the primary caret to [offset] and returns the primary caret.