-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wandb logger init to hydra runners #894
base: main
Are you sure you want to change the base?
Conversation
@@ -12,6 +12,7 @@ | |||
from typing import TYPE_CHECKING | |||
|
|||
import hydra | |||
from omegaconf import OmegaConf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this is currently a dependency, should we add this to pyproject.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its installed through hydra
Codecov ReportAttention: Patch coverage is
|
@@ -32,29 +33,48 @@ | |||
|
|||
|
|||
class Submitit(Checkpointable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, since the Runner
class is already a Checkpointable
, do we need both the Runner
and Submitit
to inherit from Checkpointable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runner is not a Checkpointable?
Add instantiation for wandb logger to the new hydra runners. The logger is a singleton logger that is only instantiated on master and independent of the runners. The runners can then just log from anywhere (without having to know all the run information) assuming the logger is instantiated.
example logger config in the yaml:
Example run: https://fairwandb.org/rgao/fairchem/runs/202410-2422-3005-86f0